Login and client command line refactoring #175
Conversation
|
@mgaffigan Is it possible to break this up into a few commits to make it easier to review? There is enough change that it's a bit difficult to mentally keep track of which changes are related to the same refactor and which aren't with all of the scrolling. |
|
@mgaffigan I'm fine with them all being part of this single PR. I was just asking if the logical chunks can be separated into multiple commits. |
|
Ah. Good call. Yes. I'll break to commits. |
mgaffigan
force-pushed
the
maint/refactor-client-login
branch
from
4229704 to
f9aad48
Compare
|
@tonygermano, not sure each commit builds in isolation, but I rewrote the history by topic. Let me know if you need anything further. |
kpalang
requested review from
a team,
gibson9583,
kayyagari,
kpalang and
tonygermano
and removed request for
a team
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
maint/refactor-client-login
branch
from
f9aad48 to
4710eae
Compare
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
…ying on global state Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
…tations Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
maint/refactor-client-login
branch
from
4710eae to
37fe874
Compare
| * @return quit | ||
| */ | ||
| public static boolean quitMac() { | ||
| return (LoginPanel.getInstance().isVisible() || (PlatformUI.MIRTH_FRAME != null && PlatformUI.MIRTH_FRAME.logout(true))); |
There was a problem hiding this comment.
What is the affect of removing the isVisible check?
Is this something Mac users need to specifically help test?
There was a problem hiding this comment.
I cannot find any code path where loginpanel is visible when MIRTH_FRAME is null. testers are welcome - and this is not a particularly critical change - I can revert.
3 participants
In support for future merge of mgaffigan:feature/add-oidc-auth