change alias name in the JKS store #186
Conversation
Signed-off-by: Christophe CHAUVET <christophe.chauvet@gmail.com>
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
This seems like a compatibility issue and barrier to switching from NG and other branches. I don't think this needs to be changed, and if it is, "mirthconnect" should still be read as back-compat. Related: #50
If there were truly a need to remove "mirth" from the codebase, a huge PR would be needed and there is definitely a compatibility break with that. Doing this piecemeal does not seem beneficial.
And if we're specifically talking about the API certificate changing from "mirthconnect", then let's make it non-vendor specific. e.g.: "https" or "apiserver"
|
There isn't a need to change internal use of "mirth" as I understand it, however at some point our jars should be updated. |
There was a problem hiding this comment.
Pull Request Overview
Changes the default certificate alias from "mirthconnect" to "oiengine" in the JKS store configuration to address SSL/TLS certificate verification issues discussed in Discord.
- Updates the certificate alias name used for default certificate generation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| */ | ||
| private void generateDefaultCertificate(Provider provider, KeyStore keyStore, char[] keyPassword) throws Exception { | ||
| final String certificateAlias = "mirthconnect"; | ||
| final String certificateAlias = "oiengine"; |
There was a problem hiding this comment.
The certificate alias should be configurable rather than hardcoded. Consider moving this to a configuration property or constant to allow easier customization without code changes.
3 participants
Follow a discussion on discord about use SSL/TLS without error about the certificate verification, i see the alias name is mirthconnect, i replace it with oiengine