Make oieserver compatible with apple bash #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
bugfix/oieserver-macos
branch
from
6101954 to
c50858b
Compare
kpalang
requested review from
a team,
jonbartels,
kayyagari,
ssrowe and
tonygermano
and removed request for
a team
kpalang
approved these changes
Nov 4, 2025
Contributor
|
For future reference, the approach used before this PR works starting with Bash 4.2, but MacOS ships with Bash 3.2. |
tonygermano
approved these changes
Nov 4, 2025
jonbartels
approved these changes
Nov 6, 2025
Contributor
jonbartels
left a comment
jonbartels
left a comment
There was a problem hiding this comment.
We shebang for bash specifically #!/usr/bin/env bash
So this is bash only and doesn't need to be comapatible with zsh the default shell in MacOS.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198