Ollama default setup #490
Merged
Ollama default setup #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and any other valid configuration for ollama and another model. Added toolsEnabled inside ChatAgent (from dev mode prototype) and refactored the rest of the code to work with it. Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
gkwan-ibm
suggested changes
Nov 5, 2025
gkwan-ibm
left a comment
gkwan-ibm
left a comment
There was a problem hiding this comment.
Also, when I turn off AI mode a, I cannot turn it back.
Did you check all scenarios in https://github.ibm.com/dev-engage/liberty-ai-dev-mode-prototype/issues/216#issue-56125826?
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <Siaa.Gor@ibm.com>
Signed-off-by: Siaa Gor <siaa.gor@ibm.com>
Signed-off-by: Siaa Gor <siaa.gor@ibm.com>
Signed-off-by: Siaa Gor <siaa.gor@ibm.com>
Signed-off-by: Siaa Gor <siaa.gor@ibm.com>
Signed-off-by: Siaa Gor <siaa.gor@ibm.com>
Member
Author
|
Hello, yes, I tested the different scenarios. I did notice in a case before ( incorrect ollama base url and correct model scenario both provided together): langchain4j throws a retryable exception and the server is configured to print the retryable exception. I am wondering if I should change this or to keep it printed along with my own error message. Thank you. |
Signed-off-by: Gilbert Kwan <gkwan@ca.ibm.com>
gkwan-ibm
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses this issue