Consume the generate features code from a common repository #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two methods were renamed (
getServerFeaturesGradle(),getClassesDirectoriesGradle()) rather than investigate whether the Groovy language implementation could be tricked into finding the methods by their old names. By the same token, these three methods use the Java method to indicate where to find them but the code still works properly if we delete the class name andthis:GenerateFeaturesTask.this.getMPVersion(),GenerateFeaturesTask.this.getEEVersion(),GenerateFeaturesTask.this.getServerFeatureUtil(). I keep this syntax to keep it the same as ci.maven and to make it clear to the reader that we are using the local method or the inherited method of the local class.Part of OpenLiberty/ci.maven#1915