Make Object Selection window modal in play mode #3370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And pause the game while it is open, using the same pause flag as browsePrompt window. Fixes OpenLoco#2914 Fixes OpenLoco#3179 Fixes OpenLoco#3369
Comment on lines
+574
to
+584
| promptTickLoop( | ||
| []() { | ||
| Input::handleKeyboard(); | ||
| Audio::updateSounds(); | ||
| WindowManager::dispatchUpdateAll(); | ||
| Input::processKeyboardInput(); | ||
| WindowManager::update(); | ||
| Ui::minimalHandleInput(); | ||
| Gfx::renderAndUpdate(); | ||
| return WindowManager::find(WindowType::objectSelection) != nullptr; | ||
| }); |
There was a problem hiding this comment.
I can see why you went with this approach, but to be honest, I'm apprehensive about adding more custom tick loops to the code base. Instead, I think we should be having less of them, rather than more. We should facilitate this blocking behaviour in another way, I think.
@ZehMatt What are your thoughts on this?
There was a problem hiding this comment.
I agree, our plan is to get rid of such special code, I think the better approach is to handle this with the scene manager, all this really requires is a flag that stops updating the scene but still renders and handles inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And pause the game while it is open, using the same pause flag as browsePrompt window. Fixes #2914
Fixes #3179
Fixes #3369