fix(log): Add error handling for file sync and close operations #1318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add error handling for
file.Sync()andfile.Close()operations in the async log writer.Problem
The
writeRoutine()function inAsyncLogWriterwas not checking errors from:file.Sync()- could fail if disk is full or I/O error occursfile.Close()- could indicate buffered writes didn't flush properlyAccording to Go best practices, errors from closing writable files should be checked as they can indicate data loss.
Changes
nhp/log/logger.gofile.Sync()andfile.Close()Test plan
🤖 Generated with Claude Code