fix(security): Set Secure flag on session cookies #1319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set the Cookie
Secureattribute totruefor session cookies in KBS auth and attest handlers.Problem
Session cookies were being set with
Secure: false, allowing them to be transmitted over unencrypted HTTP connections. This could expose session IDs to interception via man-in-the-middle attacks.Changes
endpoints/server/kbs/auth/auth.gotrueendpoints/server/kbs/attest/attest.gotrueTest plan
🤖 Generated with Claude Code