Skip to content

Conversation

@justin-layerv
Copy link
Contributor

Summary

Set the Cookie Secure attribute to true for session cookies in KBS auth and attest handlers.

Problem

Session cookies were being set with Secure: false, allowing them to be transmitted over unencrypted HTTP connections. This could expose session IDs to interception via man-in-the-middle attacks.

Changes

File Change
endpoints/server/kbs/auth/auth.go Set Cookie Secure flag to true
endpoints/server/kbs/attest/attest.go Set Cookie Secure flag to true

Test plan

  • Verify build passes
  • Verify cookies are correctly set with Secure flag in HTTPS environments
  • Confirm KBS authentication flow still works correctly

🤖 Generated with Claude Code

@justin-layerv justin-layerv self-assigned this Jan 3, 2026
wenhulove333
wenhulove333 previously approved these changes Jan 6, 2026
@wenhulove333 wenhulove333 force-pushed the fix/cookie-secure-flag branch from 4f87dc8 to fd89bea Compare January 6, 2026 05:26
@craftleon
Copy link
Contributor

Merging is blocked due to commit missing verified signatures.

@justin-layerv justin-layerv force-pushed the fix/cookie-secure-flag branch from fd89bea to b4bf36e Compare January 6, 2026 22:32
@justin-layerv justin-layerv merged commit 8892bf8 into OpenNHP:main Jan 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants