refactor(tokenstore): consolidate duplicate token store implementations #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-layerv
force-pushed
the
refactor/consolidate-tokenstore
branch
from
040f8f8 to
243be24
Compare
Extract common TokenStore functionality into a generic implementation in nhp/common/tokenstore.go. Both AC and Server now use the shared TokenStore[E] with their respective entry types. Changes: - Add generic TokenStore[E] with Store, Load, Delete, CleanExpired, and RunRefreshRoutine methods - Add TokenEntry interface for expiry time access - Refactor AC's AccessEntry to implement TokenEntry interface - Refactor Server's ACTokenEntry to implement TokenEntry interface - Remove duplicate map manipulation and refresh routine code - Add comprehensive unit tests for TokenStore This eliminates ~60 lines of duplicate code between AC and Server while maintaining their specific behaviors: - AC adds 5s buffer to expiry and extends expiry on verify - Server uses exact expiry and doesn't extend on verify
justin-layerv
force-pushed
the
refactor/consolidate-tokenstore
branch
from
243be24 to
b9e03a0
Compare
- Keep consolidated TokenStore implementation from PR - Apply import grouping style from main - Keep improved error message format from main
craftleon
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nhp/common/tokenstore.goTokenStore[E]with their respective entry typesChanges
TokenStore[E]withStore,Load,Delete,CleanExpired, andRunRefreshRoutinemethodsTokenEntryinterface for expiry time accessAccessEntryto implementTokenEntryinterfaceACTokenEntryto implementTokenEntryinterfacePreserved Behaviors
The refactoring maintains the specific behaviors of each component:
Test Plan