refactor(httpauth): deduplicate auth handler methods #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-layerv
force-pushed
the
refactor/dedupe-http-auth-handlers
branch
from
60f86e7 to
22ff81d
Compare
Extract common authentication logic from authWithAspPlugin and legacyAuthWithAspPlugin into a shared doAuthWithPlugin method. Both public methods now delegate to the common implementation, eliminating ~20 lines of duplicate code while maintaining backward compatibility. Also improves error logging by including the aspId in the error message.
justin-layerv
force-pushed
the
refactor/dedupe-http-auth-handlers
branch
from
22ff81d to
a8c5a6b
Compare
craftleon
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract common authentication logic from
authWithAspPluginandlegacyAuthWithAspPlugininto a shareddoAuthWithPluginmethod.Changes
doAuthWithPlugin()with the common implementationauthWithAspPlugin()andlegacyAuthWithAspPlugin()to delegate to the shared methodBefore
Two nearly identical 20-line functions with copy-pasted logic.
After
One 18-line implementation with two 1-line wrapper functions.
Test Plan