refactor(logging): standardize log message formatting in server package #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-layerv
force-pushed
the
refactor/standardize-log-formatting
branch
from
3c50231 to
9d50fda
Compare
- Change auth error logging from Info to Warning level (httpauth.go) - Remove trailing newlines from log messages (logger handles this) - Add colons before error values for consistency - Improve message clarity (e.g., "discarding packet from" instead of "Discard new packet from addr") This is a representative sample of log formatting fixes focused on the server package. Similar patterns exist in other packages and can be addressed in follow-up PRs.
justin-layerv
force-pushed
the
refactor/standardize-log-formatting
branch
from
9d50fda to
9f85282
Compare
- Keep standardized log formatting from PR (log.Warning for auth errors) - Remove trailing newlines from log messages - Apply import grouping style from main
craftleon
previously approved these changes
Jan 7, 2026
craftleon
approved these changes
Jan 7, 2026
craftleon
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Standardize log message formatting in the server package as a representative sample of log formatting improvements.
Changes
log.Infotolog.Warning(httpauth.go)\nfrom log messages (logger handles newlines automatically)error: %vinstead oferror %v)Files Modified
endpoints/server/httpauth.go- Auth error log levelendpoints/server/httpserver.go- HTTP server error messagesendpoints/server/udpserver.go- UDP server error and debug messagesFuture Work
Similar patterns exist in other packages (AC, Agent, DB) and can be addressed in follow-up PRs if desired.
Test Plan