fix(crypto): Add proper error handling for crypto operations #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-layerv
force-pushed
the
security/crypto-error-handling
branch
from
8524d23 to
7facc7d
Compare
Previously, cryptographic function errors were silently ignored in multiple locations, potentially returning nil cipher objects that could cause panics or undefined behavior: - NewHash() silently ignored blake2s.New256() errors - AeadFromKey() ignored cipher and GCM creation errors - CBC functions ignored cipher creation errors Changes: - NewHash() now returns (hash.Hash, error) - AeadFromKey() now returns (cipher.AEAD, error) - CBCEncryption/Decryption properly handle cipher errors - All callers updated to check returned errors - Internal helpers use panic for programming bugs (invalid params) - External APIs return errors for proper handling Files modified: - nhp/core/crypto.go (core changes) - nhp/core/responder.go (caller updates) - nhp/core/initiator.go (caller updates) - nhp/core/kdf.go (HMAC helpers) - nhp/core/ztdo/noise.go (symmetric agreement) - nhp/core/ztdo/ztdo.go (signature helpers) - nhp/core/main/nhpdevice.go (C bindings) - nhp/core/benchmark/ecc_rsa_test.go (tests) - nhp/test/ecdsa_test.go (tests) - nhp/test/packet_test.go (tests)
justin-layerv
force-pushed
the
security/crypto-error-handling
branch
from
7facc7d to
327a2bb
Compare
- Keep proper error handling from PR (returning errors instead of log+nil) - Fix typo: "invloved" -> "involved" in noise.go comment - Keep descriptive error messages for CBC encryption/decryption
craftleon
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NewHash()andAeadFromKey()functions that were silently ignoring errorsProblem
Cryptographic function errors were silently ignored in 8+ locations:
NewHash()ignoredblake2s.New256()errorsAeadFromKey()ignored cipher and GCM creation errorsThis could result in nil cipher objects being returned, causing panics or undefined behavior.
Changes
NewHash()now returns(hash.Hash, error)AeadFromKey()now returns(cipher.AEAD, error)CBCEncryption/Decryptionproperly handle cipher errorsFiles Modified
nhp/core/crypto.gonhp/core/responder.gonhp/core/initiator.gonhp/core/kdf.gonhp/core/ztdo/noise.gonhp/core/ztdo/ztdo.gonhp/core/main/nhpdevice.gonhp/core/benchmark/ecc_rsa_test.gonhp/test/ecdsa_test.gonhp/test/packet_test.goTest Plan
go build github.com/OpenNHP/opennhp/nhp/core/...go test ./core/...(benchmark and ztdo tests pass)