fix(crypto): Use full 12-byte GCM nonce with random prefix #1339
+87
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The GCM nonce only used 8 of 12 bytes. Bytes 0-4 were always zero:
This reduced effective nonce entropy and made patterns more predictable.
Solution
Use HeaderCommon bytes 12-16 (previously unused) as a random nonce prefix:
HeaderCommon Layout (24 bytes)
Files Modified
nhp/core/scheme/curve/header.gonhp/core/scheme/gmsm/header.gonhp/core/packet.gonhp/core/initiator.gonhp/core/scheme/curve/header_test.goBackward Compatibility
Test Plan
TestNonceBytesLength- Verify 12 bytes returnedTestNonceBytesContent- Verify prefix and counter placementTestNonceNoZeroGap- Verify no zero gaps when values setTestNonceUniqueness- Verify different inputs produce unique nonces