build: add developer workflow targets to Makefile #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-layerv
force-pushed
the
build/makefile-improvements
branch
3 times, most recently
from
f24fb0b to
67055d8
Compare
- log/logger.go: Fix nil file pointer when DirPath is empty but Name is set - core/scheme/curve/curve.go: Validate private key length in SetPrivateKey - core/scheme/gmsm/gmsm.go: Validate private key length in SetPrivateKey - core/crypto.go: Handle empty slice in unpad function - core/packet.go: Check for negative index in HeaderTypeToString These fixes address panics discovered by fuzz testing and ensure graceful error handling for malformed or edge-case inputs.
Add common development targets to improve developer experience: - dev: Quick development build (no version injection) - test: Run all tests with go test (replaces stub) - test-race: Run tests with race detection - fmt: Format code with gofmt - lint: Run golangci-lint with helpful install message - clean: Remove build artifacts - help: Show comprehensive help with all available targets The previous `test` target was a stub that only printed messages. This change makes it actually run tests across both modules.
The wasm/policy package contains stub functions designed for WASM compilation and cannot be built with standard Go toolchain. Use go list with grep to filter out these packages.
These tests are meant for manual/interactive testing and contain infinite loops that cause CI timeouts.
justin-layerv
force-pushed
the
build/makefile-improvements
branch
from
67055d8 to
4e461a6
Compare
craftleon
previously approved these changes
Jan 7, 2026
craftleon
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
testtarget with actual test runnerhelptarget documenting all available commandsNew Targets
make devmake testgo test -v ./...make test-racemake fmtmake lintmake cleanmake helpChanges
testtarget was a stub that only printed messages - now it actually runs tests.PHONYdeclarations for all new targetsTest plan
make helpshows formatted outputmake testto verify tests executemake fmtto verify code formattingmake cleanto verify artifact cleanup