fix(lint): enable errcheck linter and fix all unchecked errors #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
errchecklinter in golangci-lint configurationChanges
Configuration
.golangci.yml: Moveerrcheckfromdisabletoenablelist, remove test file exclusion for errchecknhp module (24 issues fixed)
core/scheme/curve/curve.go:
SetPrivateKeyerror returncore/ztdo/noise.go:
rand.Readreturn (crypto/rand never fails)core/ztdo/ztdo.go:
EncryptandDecryptSetMetadataandSetCipherTextreturnsmarshalerror intoBufferlog/logger.go:
Outputerrors (logging failures are non-critical)file.Syncerrorutils/file.go:
watcher.Adderrorendpoints module (50 issues fixed)
ac/:
httpServer.Shutdown,ipset.Add,SendPacketerrorsHandleUdpACOperationsgoroutine call to handle erroragent/:
preAccessRequest,processPreAccessActionerrorsSendPacket,SaveStructAsJsonFile,ExitKnockRequesterrorsdb/:
SetMetadata,SetNhpServer,dataPrkStore.SaveerrorsSendPacket,fromJson,file.WriteerrorsHandleUdpDataKeyWrappingOperationsgoroutine call to handle errorserver/:
updateXxxfunction errors in etcd config updateTest plan
golangci-lint run ./...passes on both modules with 0 issuesCloses #1372
🤖 Generated with Claude Code