fix(worker): Handle newline normalization at boundary of streamed chunks#3838
Merged
fix(worker): Handle newline normalization at boundary of streamed chunks#3838
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3838 +/- ##
==========================================
+ Coverage 45.40% 45.48% +0.07%
==========================================
Files 650 650
Lines 34957 34969 +12
Branches 1711 1711
==========================================
+ Hits 15873 15904 +31
+ Misses 18902 18883 -19
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportBundle size has no change ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When normalizing newlines during git edits we could fail to handle newline edits at the boundaries of the chunk or if none appeared in the first chunk. Add coverage for this normalization.