Skip to content

fix(worker): Handle newline normalization at boundary of streamed chunks#3838

Merged
nellh merged 1 commit intomasterfrom
normalize-line-ending-boundary-fixes
Mar 25, 2026
Merged

fix(worker): Handle newline normalization at boundary of streamed chunks#3838
nellh merged 1 commit intomasterfrom
normalize-line-ending-boundary-fixes

Conversation

@nellh
Copy link
Copy Markdown
Contributor

@nellh nellh commented Mar 25, 2026

When normalizing newlines during git edits we could fail to handle newline edits at the boundaries of the chunk or if none appeared in the first chunk. Add coverage for this normalization.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.48%. Comparing base (3e69eac) to head (fe22d16).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
services/datalad/datalad_service/common/git.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3838      +/-   ##
==========================================
+ Coverage   45.40%   45.48%   +0.07%     
==========================================
  Files         650      650              
  Lines       34957    34969      +12     
  Branches     1711     1711              
==========================================
+ Hits        15873    15904      +31     
+ Misses      18902    18883      -19     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Bundle Report

Bundle size has no change ✅

@nellh nellh merged commit 6fb2272 into master Mar 25, 2026
18 checks passed
@nellh nellh deleted the normalize-line-ending-boundary-fixes branch March 25, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant