fix(server): Prevent throwing an error on createSnapshot mutation if reindex queue fails#3840
Merged
fix(server): Prevent throwing an error on createSnapshot mutation if reindex queue fails#3840
Conversation
…reindex queue fails Reindexing here isn't critical. Log the underlying error and this will still be indexed by the routine reindex.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3840 +/- ##
==========================================
- Coverage 45.48% 45.46% -0.02%
==========================================
Files 650 650
Lines 34969 34977 +8
Branches 1711 1711
==========================================
Hits 15904 15904
- Misses 18883 18891 +8
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportBundle size has no change ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3839 by preventing this error from throwing during the createSnapshot mutation. It's not critical to queue a reindex and it will be indexed by the routine indexing if this fails. Log the underlying errors to Sentry.