Skip to content

fix(server): Prevent throwing an error on createSnapshot mutation if reindex queue fails#3840

Merged
nellh merged 1 commit intomasterfrom
snapshot-apollo-error
Mar 26, 2026
Merged

fix(server): Prevent throwing an error on createSnapshot mutation if reindex queue fails#3840
nellh merged 1 commit intomasterfrom
snapshot-apollo-error

Conversation

@nellh
Copy link
Copy Markdown
Contributor

@nellh nellh commented Mar 25, 2026

Fixes #3839 by preventing this error from throwing during the createSnapshot mutation. It's not critical to queue a reindex and it will be indexed by the routine indexing if this fails. Log the underlying errors to Sentry.

…reindex queue fails

Reindexing here isn't critical. Log the underlying error and this will still be indexed by the routine reindex.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.46%. Comparing base (600e880) to head (b9a09e7).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...es/openneuro-server/src/queues/producer-methods.ts 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3840      +/-   ##
==========================================
- Coverage   45.48%   45.46%   -0.02%     
==========================================
  Files         650      650              
  Lines       34969    34977       +8     
  Branches     1711     1711              
==========================================
  Hits        15904    15904              
- Misses      18883    18891       +8     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Bundle Report

Bundle size has no change ✅

@nellh nellh merged commit e83f6e4 into master Mar 26, 2026
16 of 18 checks passed
@nellh nellh deleted the snapshot-apollo-error branch March 26, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ApolloError on successful snapshot

1 participant