Skip to content

fix: Resolve reviewer access regression#3849

Merged
nellh merged 3 commits intomasterfrom
reviewer-link-regression
Mar 30, 2026
Merged

fix: Resolve reviewer access regression#3849
nellh merged 3 commits intomasterfrom
reviewer-link-regression

Conversation

@nellh
Copy link
Copy Markdown
Contributor

@nellh nellh commented Mar 30, 2026

Fixes reviewer users being immediately logged out and provides better compatibility for the frontend code by generating a mock user object for reviewers. Includes a fix to hide write actions from reviewers, previously a reviewer could make these requests even though they would throw errors.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Bundle Report

Changes will increase total bundle size by 161 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@openneuro/app-esm 16.14MB 161 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @openneuro/app-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 121 bytes 977.43kB 0.01%
assets/dataset-*.js 40 bytes 388.65kB 0.01%

Files in assets/index-*.js:

  • ./src/scripts/users/user-menu.tsx → Total Size: 3.31kB

Files in assets/dataset-*.js:

  • ./src/scripts/dataset/snapshot-container.tsx → Total Size: 11.51kB

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 1.78571% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.43%. Comparing base (fb46610) to head (3fa3fe0).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ages/openneuro-app/src/scripts/users/user-menu.tsx 0.00% 28 Missing ⚠️
...ges/openneuro-server/src/graphql/resolvers/user.ts 0.00% 23 Missing ⚠️
...uro-app/src/scripts/dataset/snapshot-container.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3849      +/-   ##
==========================================
- Coverage   45.46%   45.43%   -0.04%     
==========================================
  Files         650      650              
  Lines       34977    35006      +29     
  Branches     1711     1711              
==========================================
  Hits        15904    15904              
- Misses      18891    18920      +29     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nellh nellh merged commit d4b3ac6 into master Mar 30, 2026
16 of 18 checks passed
@nellh nellh deleted the reviewer-link-regression branch March 30, 2026 19:43
@effigies
Copy link
Copy Markdown
Contributor

This was a regression introduced in #3829?

@nellh
Copy link
Copy Markdown
Contributor Author

nellh commented Mar 31, 2026

This was a regression introduced in #3829?

Yes. The user query would always fail for reviewer users and handling that error in the client meant we'd log them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants