fix: Resolve reviewer access regression#3849
Merged
Conversation
Bundle ReportChanges will increase total bundle size by 161 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @openneuro/app-esmAssets Changed:
Files in
Files in
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3849 +/- ##
==========================================
- Coverage 45.46% 45.43% -0.04%
==========================================
Files 650 650
Lines 34977 35006 +29
Branches 1711 1711
==========================================
Hits 15904 15904
- Misses 18891 18920 +29
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This was a regression introduced in #3829? |
Contributor
Author
Yes. The user query would always fail for reviewer users and handling that error in the client meant we'd log them out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes reviewer users being immediately logged out and provides better compatibility for the frontend code by generating a mock user object for reviewers. Includes a fix to hide write actions from reviewers, previously a reviewer could make these requests even though they would throw errors.