-
Notifications
You must be signed in to change notification settings - Fork 30
Track3d #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track3d #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the legacy ptv.c code into a new track3d.c implementation with Cython bindings while adding 3D tracking support and corresponding tests. Key changes include:
- Adding new 3D tracking routines and Cython binding methods in tracker.pyx and tracker.pxd.
- Introducing new unit tests for 3D tracking in both Python (py_bind/test/) and C (liboptv/tests/check_track3d.c).
- Updating CMake configuration and versioning to integrate the new track3d module.
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| py_bind/test/test_tracker.py | Added new tests for 3D tracking functionality using forward steps. |
| py_bind/test/test_burgers.py | Introduced similar 3D tracking tests specific to the Burgers case. |
| py_bind/optv/tracker.pyx | Added step_forward_3d and full_forward_3d methods for 3D tracking. |
| liboptv/src/track3d.c | New C implementation for 3D tracking integrating track3d_loop logic. |
| liboptv/tests/check_track3d.c | New test suite for verifying 3D tracking results. |
| CMakeLists.txt files in both liboptv/src and liboptv/tests | Updated to compile and link against the new track3d module. |
Comments suppressed due to low confidence (1)
liboptv/src/track3d.c:65
- [nitpick] Consider renaming 'count1' to a more descriptive identifier such as 'link_count' to improve code readability.
int count1 = 0; // Count of links established in level 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
liboptvandpy_bindtests pass