Issue 412 - Fix incorrect dialog parents#414
Merged
zdohnal merged 1 commit intoOpenPrinting:masterfrom Jan 8, 2026
Merged
Conversation
Contributor
Author
|
There are other instances where the code uses self.parent in dialogs, but I am unsure if these are errors or not. |
Member
|
Hi @shartrec , thank you for the PR! I have tested the printing test page and it looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed show_info_dialog and show_error_dialog to use the printerproperties dialog as their parent rather than the parent to correct wrong window stacking in well behaved (strict) window managers