Skip to content

title_editor: fix multi-lines titles update error if missing line 1 (Fixes #5864) #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tlvu wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

title_editor: fix multi-lines titles update error if missing line 1 (Fixes #5864) #5865

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1394617
title_editor: fix multi-lines titles update error if missing line 1
tlvu Dec 1, 2025
8530770
title_editor: mark previously empty field not updatable
tlvu Dec 1, 2025
33eb9eb
title_editor: allow update previously empty fields
tlvu Dec 1, 2025
d0a2584
Revert "title_editor: mark previously empty field not updatable"
tlvu Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/windows/title_editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,11 @@ def txtLine_changed(self, txtWidget):

# Update text values in the SVG
for i, node in enumerate(self.tspan_nodes):
if len(node.childNodes) > 0 and i <= (len(text_list) - 1):
if i <= (len(text_list) - 1):
new_text_node = self.xmldoc.createTextNode(text_list[i])
old_text_node = node.childNodes[0]
node.removeChild(old_text_node)
if len(node.childNodes) > 0:
old_text_node = node.childNodes[0]
node.removeChild(old_text_node)
# add new text node
node.appendChild(new_text_node)

Expand Down Expand Up @@ -409,8 +410,9 @@ def load_svg_template(self, filename_field=None):
title_text = []
for i, node in enumerate(self.tspan_nodes):
if len(node.childNodes) < 1:
continue
text = node.childNodes[0].data
text = ""
else:
text = node.childNodes[0].data
title_text.append(text)

# Create Label
Expand Down