Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,3 @@ inherit_gem:

Layout/LineLength:
Max: 225

AllCops:
TargetRubyVersion: '3.2'
37 changes: 27 additions & 10 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --no-auto-gen-timestamp`
# using RuboCop version 1.79.2.
# using RuboCop version 1.81.7.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -115,13 +115,13 @@ Lint/SymbolConversion:

# Offense count: 25
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect, IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument:
Enabled: false

# Offense count: 8
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
# NotImplementedExceptions: NotImplementedError
Lint/UnusedMethodArgument:
Exclude:
Expand All @@ -132,14 +132,13 @@ Lint/UnusedMethodArgument:

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect, ContextCreatingMethods, MethodCreatingMethods.
# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
Lint/UselessAccessModifier:
Exclude:
- 'lib/packaging/sign.rb'

# Offense count: 9
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect.
Lint/UselessAssignment:
Exclude:
- 'lib/packaging/repo.rb'
Expand All @@ -152,7 +151,7 @@ Lint/UselessAssignment:

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect, CheckForMethodsWithNoSideEffects.
# Configuration parameters: CheckForMethodsWithNoSideEffects.
Lint/Void:
Exclude:
- 'lib/packaging/nuget.rb'
Expand Down Expand Up @@ -434,6 +433,16 @@ RSpec/LeakyConstantDeclaration:
Exclude:
- 'spec/lib/packaging/config_spec.rb'

# Offense count: 53
RSpec/LeakyLocalVariable:
Exclude:
- 'spec/lib/packaging/artifactory_spec.rb'
- 'spec/lib/packaging/config_spec.rb'
- 'spec/lib/packaging/paths_spec.rb'
- 'spec/lib/packaging/retrieve_spec.rb'
- 'spec/lib/packaging/util/net_spec.rb'
- 'spec/lib/packaging/util/ship_spec.rb'

# Offense count: 9
# This cop supports safe autocorrection (--autocorrect).
RSpec/MatchArray:
Expand Down Expand Up @@ -532,14 +541,13 @@ RSpec/ReturnFromStub:

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect.
RSpec/ScatteredLet:
Exclude:
- 'spec/lib/packaging/artifactory_spec.rb'

# Offense count: 2
# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
# Include: **/*_spec.rb
# Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata, InflectorPath, EnforcedInflector.
# SupportedInflectors: default, active_support
RSpec/SpecFilePathFormat:
Exclude:
- '**/spec/routing/**/*'
Expand Down Expand Up @@ -772,7 +780,7 @@ Style/EmptyCaseCondition:

# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect, EnforcedStyle.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Exclude:
Expand Down Expand Up @@ -1150,6 +1158,15 @@ Style/RedundantRegexpArgument:
- 'lib/packaging/deb.rb'
- 'lib/packaging/util/version.rb'

# Offense count: 6
# This cop supports safe autocorrection (--autocorrect).
Style/RedundantRegexpEscape:
Exclude:
- 'lib/packaging/nuget.rb'
- 'lib/packaging/paths.rb'
- 'lib/packaging/util/version.rb'
- 'tasks/deb.rake'

# Offense count: 70
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowMultipleReturnValues.
Expand Down
2 changes: 1 addition & 1 deletion packaging.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
gem.required_ruby_version = '>= 3.2.0'

gem.add_development_dependency('rspec', ['>= 2.14.1', '< 4'])
gem.add_development_dependency('voxpupuli-rubocop', '~> 4.2.0')
gem.add_development_dependency('voxpupuli-rubocop', '~> 5.1.0')
gem.add_dependency('artifactory', ['~> 3'])
gem.add_dependency('base64', ['< 0.4'])
gem.add_dependency('benchmark', '< 0.6')
Expand Down