Custom template font #790
Custom template font #790
Conversation
Summary of ChangesHello @MakinoharaShoko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求引入了对自定义模板字体的支持，允许游戏开发者通过 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| logger.info(`WebGAL v${__INFO.version}`); | ||
| logger.info('Github: https://github.com/OpenWebGAL/WebGAL '); | ||
| logger.info('Made with ❤ by OpenWebGAL'); | ||
| loadTemplate(); |
There was a problem hiding this comment.
loadTemplate 是一个异步函数，但在这里它被同步调用（“fire-and-forget”模式）。这可能会导致竞态条件：在 loadTemplate 完成加载模板和字体之前，后续的初始化代码（如 sceneFetcher）可能已经开始执行。如果场景依赖于模板中定义的自定义字体，字体可能无法被正确应用，或导致内容闪烁（FOUT）。为了保证初始化顺序的正确性，建议将 initializeScript 函数修改为 async 函数，并使用 await 等待 loadTemplate 完成。
| if (/^(https?:)?\/\//i.test(path) || path.startsWith('data:')) { | ||
| return path; | ||
| } | ||
| const normalized = path.replace(/^[./]+/, ''); |
There was a problem hiding this comment.
resolveTemplateAssetPath 函数中的路径规范化逻辑 path.replace(/^[./]+/, '') 会将以 ../ 开头的路径（例如 ../fonts/myfont.woff）静默地处理成 fonts/myfont.woff。这可能会让模板制作者感到困惑，因为他们可能期望路径能够回溯到上级目录。虽然这可能是出于安全考虑，将资源限制在模板目录内，但这种隐式行为容易引发错误。建议添加一个警告日志，当检测到路径中包含 .. 时通知用户，以避免意外行为。
在模板的描述文件 template.json 中，添加了 font 字段，用于描述用户的自定义字体。这一字体由引擎在初始化阶段通过插入 style 标签的方式被加载到页面中，并在 Options 中注册并成为可选项。
如果有自定义字体，其将会被添加到默认字体之前的位置。并且由于引擎默认选中第一个字体作为对话框和选项等 UI 的字体，所以一般来说自定义字体会被优先选中。