Skip to content

Fix type errors in models #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type errors in models #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions xbox/webapi/api/provider/gameclips/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from datetime import datetime
from typing import List, Optional

from xbox.webapi.common.models import CamelCaseModel
Expand All @@ -6,24 +7,24 @@
class Thumbnail(CamelCaseModel):
uri: str
file_size: int
thumbnail_type: str
thumbnail_type: int


class GameClipUri(CamelCaseModel):
uri: str
file_size: int
uri_type: str
uri_type: int
expiration: str


class GameClip(CamelCaseModel):
game_clip_id: str
state: str
date_published: str
date_recorded: str
last_modified: str
state: int
date_published: datetime
date_recorded: datetime
last_modified: datetime
user_caption: str
type: str
type: int
duration_in_seconds: int
scid: str
title_id: int
Expand All @@ -41,7 +42,7 @@ class GameClip(CamelCaseModel):
clip_name: str
title_name: str
game_clip_locale: str
clip_content_attributes: str
clip_content_attributes: int
device_type: str
comment_count: int
like_count: int
Expand Down
10 changes: 5 additions & 5 deletions xbox/webapi/api/provider/screenshots/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,26 @@
class Thumbnail(CamelCaseModel):
uri: str
file_size: int
thumbnail_type: str
thumbnail_type: int


class ScreenshotUri(CamelCaseModel):
uri: str
file_size: int
uri_type: str
uri_type: int
expiration: datetime


class Screenshot(CamelCaseModel):
screenshot_id: str
resolution_height: int
resolution_width: int
state: str
state: int
date_published: datetime
date_taken: datetime
last_modified: datetime
user_caption: str
type: str
type: int
scid: str
title_id: int
rating: float
Expand All @@ -43,7 +43,7 @@ class Screenshot(CamelCaseModel):
screenshot_name: str
title_name: str
screenshot_locale: str
screenshot_content_attributes: str
screenshot_content_attributes: int
device_type: str


Expand Down
4 changes: 2 additions & 2 deletions xbox/webapi/api/provider/titlehub/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ class Detail(CamelCaseModel):
availabilities: List[Availability]
capabilities: List[str]
description: str
developer_name: str
developer_name: str | None = None
genres: Optional[List[str]] = None
publisher_name: str
min_age: Optional[int] = None
min_age: int | None = None
release_date: Optional[datetime] = None
short_description: Optional[str] = None
vui_display_name: Optional[str] = None
Expand Down