Add generate_spy_event_helpers macro #1481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add verification of indexed keys in event assertions
- Tests will fail if indexed fields are changed in event definitions - Must explicitly specify expected indexed fields
…into feature/check-indexed-keys-#1054
…into feature/check-indexed-keys-#1054
…into feature/check-indexed-keys-#1054
…luding AccessControl, Ownable, Account, EthAccount, Votes, Pausable, ERC1155, ERC20, ERC4626, and ERC721. Each test verifies the correct indexed keys for events such as role grants, ownership transfers, and token transfers.
…rki/cairo-contracts into feat/check-indexed-keys-#1054
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 85 85
Lines 2278 2278
=======================================
Hits 2104 2104
Misses 174 174 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
immrsd
reviewed
Aug 5, 2025
Collaborator
immrsd
left a comment
immrsd
left a comment
There was a problem hiding this comment.
Looking good! Left a suggestion to introduce a helper trait for building expected events
…eat/check-indexed-keys-#1054
…eat/check-indexed-keys-#1054
…dd-spy-event-helper-macro
…eat/refactor-macros-package-for-v2-##1485
…eat/add-spy-event-helper-macro
…dd-spy-event-helper-macro
…dd-spy-event-helper-macro
Contributor
🧪 Cairo Contract Size Benchmark DiffBYTECODE SIZE (felts) (limit: 81,920 felts)No changes in felts. SIERRA CONTRACT CLASS SIZE (bytes) (limit: 4,089,446 bytes)No changes in bytes. This comment was generated automatically from benchmark diffs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1480
This PR is still missing documentation, and we can improve: