Skip to content

refactor(contracts): inline witnesses into the simulators#381

Draft
0xisk wants to merge 3 commits intomainfrom
refactor/witnesses
Draft

refactor(contracts): inline witnesses into the simulators#381
0xisk wants to merge 3 commits intomainfrom
refactor/witnesses

Conversation

@0xisk
Copy link
Member

@0xisk 0xisk commented Mar 11, 2026

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

This PR proposes changes on the structure of the witnessess through the repo, inspired by the midnight-apps repo structure.

PR Checklist

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c4d965d-28ae-4e52-bcaa-8c3a4b5a88e0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/witnesses

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xisk 0xisk self-assigned this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants