fix(ci): add build step to check-versions workflow #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check-versions workflow runs update-export-versions which needs to run vitest tests when versions change. These tests require adapter packages to be built (dist/index.js must exist) for the Vite plugin to resolve dynamic imports. Without the build step, tests fail with: "Failed to resolve import @openzeppelin/ui-builder-adapter-evm" This was never caught before because regular PRs have versions in sync (no tests run). Only the changeset-release PR has version mismatches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
check-versions.ymlworkflowupdate-export-versionswhich needs built packages to run testsProblem
The
check-versionsworkflow was failing on the changeset-release PR with:Root Cause
The
update-export-versionsscript runs vitest tests only when versions change. The vitest plugin resolves adapter imports to../adapter-evm/dist/index.js, which requires packages to be built.This is why it worked before - regular PRs never triggered tests because versions were always in sync. Only the changeset-release PR has mismatched versions.
Fix
Add the build step (matching
update-versions.yml):Test Plan