feat(adapter-stellar): add two-step admin transfer support #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AdminTransferInfo type and related interfaces for admin two-step transfers - Add getAdminInfo(), acceptAdminRole(), isAdminTransferExpired() methods - Add queryPendingAdminTransfer() to indexer client - Add ADMIN_TRANSFER_INITIATED and ADMIN_TRANSFER_COMPLETED event types - Add OWNERSHIP_TRANSFER_STARTED and OWNERSHIP_TRANSFER_COMPLETED event types - Remove deprecated TRANSFERRED legacy type from HistoryChangeType - Remove redundant on-chain verification for pending transfers - Make integration tests stricter (fail instead of skip for missing data) - Fix: Remove hardcoded API key from tests, require INDEXER_URL env var BREAKING CHANGE: TRANSFERRED removed from HistoryChangeType, use OWNERSHIP_TRANSFER_COMPLETED instead
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address PR review: Defaulting to GRANTED for unknown event types could mask indexer schema issues. Now using a dedicated UNKNOWN type to make these cases visible during development and debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getAdminInfo(),transferAdminRole(),acceptAdminTransfer()methods to servicequeryPendingAdminTransfer()to indexer client for pending admin transfersADMIN_TRANSFER_INITIATED,ADMIN_TRANSFER_COMPLETED,OWNERSHIP_TRANSFER_STARTED,OWNERSHIP_TRANSFER_COMPLETEDTRANSFERREDlegacy type fromHistoryChangeType(useOWNERSHIP_TRANSFER_COMPLETEDinstead)INDEXER_URLenv varType Extensions
AdminStatetype for admin states ('active' | 'pending' | 'expired' | 'renounced')PendingAdminTransferinterface for pending admin transfer detailsAdminInfointerface for admin information with state and pending transferAccessControlCapabilitieswithhasTwoStepAdminflagBreaking Changes
GetOwnershipOptionsinterface andverifyOnChainoption fromgetOwnership()andgetAdminInfo()readPendingOwner()function from onchain-readergetOwnership(contractAddress, options?)->getOwnership(contractAddress)TRANSFERREDfromHistoryChangeType- useOWNERSHIP_TRANSFER_COMPLETEDinsteadTest plan
INDEXER_URLis not set