-
Notifications
You must be signed in to change notification settings - Fork 7
Footer and Events Page #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for asme-nitr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dist/assets/index-Dd617RC6.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in .gitignore, write 'dist' in a new line, this shouldn't be pushed to the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not install any library, all the necessary libraries are provided, if you need specific library, ask in the group first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you meant to do this :
import { Outlet } from "react-router";
const Playground = () => {
return
<>
<div className="min-h-screen">
<Outlet />
</div>
<Footer />
</>;
};
export default Playground;
currently this is only returning the outlet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map everything from config files,
for example, instead of doing this:
<li>
<Link to="/about" className="hover:underline">
About us
</Link>
</li>
<li>
<Link to="/team" className="hover:underline">
Team
</Link>
</li>
<li>
<Link to="/events" className="hover:underline">
Events
</Link>
</li>
<li>
<Link to="/achievements" className="hover:underline">
Achievements
</Link>
</li>
<li>
<Link to="/gallery" className="hover:underline">
Gallery
</Link>
</li>
you can do this instead:
// make a file in config folder for this
const footerLinks = [
{
to : "/facebook"
text : "facebook"
}, ..... //make objects for each link
]
// and in this Footer.jsx file,
footerLinks.map((item,idx)=>{
<li>
<Link to={item.to} className="hover:underline">
{item.text}
</Link>
</li>
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
Updated playground.jsx and removed main layout page. Also incorporated separate event cards.
No description provided.