feat(weather): weather impact summaries (outdoor/driving/allergy)#544
Open
feat(weather): weather impact summaries (outdoor/driving/allergy)#544
Conversation
Add rule-based impact summaries derived from existing forecast and
environmental data. Three areas are covered:
- Outdoor: comfort bands from feels-like temperature, UV index modifier,
active-precipitation modifier.
- Driving: visibility thresholds, precipitation-type detection (ice > snow >
thunder > rain), near-freezing black-ice warning, wind severity bands.
- Allergy: pollen category/index bands with primary allergen label, wind
dispersion note, and air quality modifier.
Impact lines appear as labelled metrics in current conditions
("Impact: Outdoor / Driving / Allergy") and are included in the
fallback text read by screen readers. ForecastPresentation gains an
impact_summary derived from the first daily period.
No new API dependencies. Rule set is fully documented and covered by
76 new unit tests.
Closes #324
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #324
Adds rule-based weather impact summaries derived from existing data — no new API dependencies required.
Impact summaries appear as labelled metrics in current conditions and forecast sections. Screen readers get concise, consistently-structured lines like
Impact: Outdoor: Comfortable - good conditions for outdoor activities.What changed
src/accessiweather/impact_summary.pysrc/accessiweather/display/weather_presenter.pyimpact_summaryfield toCurrentConditionsPresentationandForecastPresentationsrc/accessiweather/display/presentation/current_conditions.pybuild_impact_summary, appends threeMetricrows, attachesImpactSummaryto presentationsrc/accessiweather/display/presentation/forecast.pybuild_forecast_impact_summaryfrom first daily period, attaches toForecastPresentationtests/test_impact_summary.pyCHANGELOG.mdTest plan
pytest tests/test_impact_summary.py— 76 tests, all passingpytest tests/— 3110 passed, 4 skipped, 0 failures🤖 Generated with Claude Code