fix(config): persist AVWX API key across sessions via keyring#560
Merged
fix(config): persist AVWX API key across sessions via keyring#560
Conversation
BUG 1: refresh_runtime_settings() now updates weather_client._avwx_api_key after a portable bundle import, matching the pattern used for visual_crossing and pirate_weather keys. BUG 2: _load_secure_keys() in config_manager now includes avwx_api_key in both portable_api_keys and secure_keys, so it is wrapped in a LazySecureStorage object at startup and loaded from keyring on first access — matching the behaviour of the other API keys. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.py):refresh_runtime_settings()now updatesweather_client._avwx_api_keyafter a portable bundle import, matching the existing pattern forvisual_crossingandpirate_weatherkeys.config_manager.py):_load_secure_keys()now includesavwx_api_keyin bothportable_api_keysandsecure_keys, so it is wrapped in aLazySecureStorageat startup and loaded from keyring on first access — matching the behaviour of the other two API keys. Previously the key was always read as a plain empty string, so any saved AVWX key was silently ignored on restart.Test plan
keyring get accessiweather avwx_api_key)weather_client._avwx_api_keyis updated immediately without needing a restartpytest -m "not integration"to confirm no regressions🤖 Generated with Claude Code