Open
Conversation
malinaalina
commented
Jan 25, 2026
malinaalina
commented
- Переход на корутины в CatsPresenter
- Добавлен запрос и отображение изображения вместе с фактом о котах
- Создана CatsViewModel
| CrashMonitor.trackWarning() | ||
| handelError(throwable) | ||
| } | ||
| private var _catsView: ICatsView? = null |
There was a problem hiding this comment.
вьюмодель не должна держать ссылку и вообще знать ничего про вью
| } | ||
| } | ||
|
|
||
| fun attachView(catsView: ICatsView) { |
| CrashMonitor.trackWarning() | ||
| val errorMsg = when (e) { | ||
| is java.net.SocketTimeoutException -> "Не удалось получить ответ от сервером" | ||
| is CancellationException -> "" |
There was a problem hiding this comment.
нужно пробросить дальше, иначе сломается отмена
is CancellationException -> throw e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.