ДЗ ReactiveCats #214
Open
ДЗ ReactiveCats #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data class Error(val message: String) : Result() | ||
| object ServerError : Result() No newline at end of file | ||
| sealed class Result { | ||
| data class Success(val fact: Single<Fact>) : Result() |
There was a problem hiding this comment.
Хранится Single, а в MainActivity используется result.fact как Fact
Мы уже получили значение из RxJava цепочки в subscribe, поэтому нужно хранить сам Fact, а не Single. Измените на data class Success(val fact: Fact)
| .observeOn(AndroidSchedulers.mainThread()) | ||
| .subscribe( | ||
| { fact -> | ||
| _catsLiveData.value = Result.Success(Single.just(fact)) |
There was a problem hiding this comment.
Здесь передается Single.just(fact)
Если исправить sealed, то тут будет Result.Success(fact)
| compositeDisposable.add(disposable) | ||
| } | ||
|
|
||
| private fun handleError(throwable: Throwable) { |
There was a problem hiding this comment.
Метод не используется и его можно удалить
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.