Open
Conversation
AJIEKCX
reviewed
Jul 1, 2025
| // TODO | ||
| override fun visitDotQualifiedExpression(expression: KtDotQualifiedExpression) { | ||
| super.visitDotQualifiedExpression(expression) | ||
| val isGlobalScopeUsing = expression.firstChild.text == "GlobalScope" |
Collaborator
There was a problem hiding this comment.
Вместо firstChild и lastChild более идиоматичным будет использование receiverExpression и selectorExpression
| override fun visitDotQualifiedExpression(expression: KtDotQualifiedExpression) { | ||
| super.visitDotQualifiedExpression(expression) | ||
| val isGlobalScopeUsing = expression.firstChild.text == "GlobalScope" | ||
| if (isGlobalScopeUsing) { |
Collaborator
There was a problem hiding this comment.
Предпочитайте ранние возвраты из функций, чтобы не делать вложенные if
| // TODO | ||
| override fun visitNamedFunction(function: KtNamedFunction) { | ||
| super.visitNamedFunction(function) | ||
| val isSuspend = function.firstChild.text == "suspend" |
Collaborator
There was a problem hiding this comment.
Модификатор suspend лучше проверять через список модификаторов: function.modifierList?.hasSuspendModifier()
| ] | ||
|
|
||
| // e.g. GlobalScope.launch { | ||
| val isCoroutineScopeClass = (descriptor as? DeserializedClassDescriptor) |
Collaborator
There was a problem hiding this comment.
В целом здесь можно было не разделять на разные дескрипторы, достаточно было получить тип у receiverExpression и проверить, что его fqName равен kotlinx.coroutines.CoroutineScope, но так тоже можно
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.