Draft
Conversation
Rework barrier release to a two-step process by adding
|
dan-woz
reviewed
Oct 28, 2025
Collaborator
dan-woz
left a comment
There was a problem hiding this comment.
Gonna chuckle if this is the problem. Deserialization: free until it's not 😔
dan-woz
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
AtMostOnceBarrierlogic to improve reliability when scheduling workflow completion callbacks. The core change is to separate the confirmation of barrier release from the initial barrier wait, ensuring that expensive workflow deserialization succeeds before marking the barrier as released. This decreases the risk of missed callback executions if a worker crashes during deserialization.