Conversation
dan-woz
approved these changes
Jun 20, 2025
Collaborator
dan-woz
left a comment
dan-woz
left a comment
There was a problem hiding this comment.
Ah yes, the dangers of implementing private access on vibes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of how the double underscore prefix (
__) works,hasattr(self, "__cached_middleware")never returned true and thefor middleware in self.broker.middlewareloop ran on every invocation. This PR fixes the problem by moving to a single_prefix. Alternatively we could check forhasattr(self, "_Workflow__cached_middleware")but that feels like assuming a CPython implementation detail.I also considered using
@cached_propertybut that uses__dict__internally which is potentially problematic from a memory perspective since aWorkflowcan be gigantic.