Skip to content

Conversation

@biqiboqi
Copy link
Contributor

No description provided.

This was linked to issues Oct 23, 2025
@bialger
Copy link
Contributor

bialger commented Oct 23, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1 @@
#include "ClassDecl.hpp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Implement Accept methods for AST nodes

Each AST node header declares an Accept(AstVisitor&) override, but the corresponding .cpp files (e.g., ClassDecl.cpp) contain only the header include and no definition. Because the classes are non‑abstract, any translation unit that calls ClassDecl::Accept will fail to link and the visitor pattern cannot be used. Provide definitions that dispatch to the appropriate AstVisitor::Visit methods.

Useful? React with 👍 / 👎.

Copy link
Contributor

@bialger bialger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, titanic work has been done. It is fantastic, and I don't see any major architecture flaws. Although there is a place to grow and some simple mistakes. Please fix them. Really good job, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement AST structure Create and push parser interfaces

3 participants