Fetch hanges #25
Fetch hanges #25
Conversation
…cy in preprocessor tests
… for submodule management
Add preprocessor tests
…ecks and ignore cache files
…apper for multi-operator and keyword checks
Preprocessor (•)(•)
…rror handling in tokenization
Lexer refactoring
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| std::unique_ptr<TokenImportProcessor> import_processor = | ||
| std::make_unique<TokenImportProcessor>(parameters.main_file, parameters.include_paths); | ||
| processors.push_back(std::move(import_processor)); | ||
|
|
||
| std::unique_ptr<TokenDirectivesProcessor> directives_processor = |
There was a problem hiding this comment.
The preprocessor pipeline now runs the import pass before any directive handling. MakeTokenProcessors constructs the TokenImportProcessor and executes it ahead of TokenDirectivesProcessor, while TokenImportProcessor::GatherDependencies blindly loads every #import it encounters. This means an import nested inside a #ifdef or #ifndef that will later be skipped is still resolved, so a missing file inside a disabled branch will raise an error and dependencies are added even when the directive evaluates to false. Imports should either be evaluated after directives or the importer must understand the skip state so that conditional imports are ignored when their branch is inactive.
Useful? React with 👍 / 👎.
No description provided.