ERST: Tomcat relative oxalis home#625
Open
nemhandel4erst wants to merge 1 commit intoOxalisCommunity:masterfrom
Open
ERST: Tomcat relative oxalis home#625nemhandel4erst wants to merge 1 commit intoOxalisCommunity:masterfrom
nemhandel4erst wants to merge 1 commit intoOxalisCommunity:masterfrom
Conversation
Collaborator
|
As you maybe noticed, 2 other changes in Oxalis I have already copied from ERST code base - described in the task #623 and OxalisCommunity/Oxalis-AS4#206 with linked pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Erhvervsstyrelsen (ERST) has implemented a Tomcat relative property home detector. It takes a property RELATIVE_OXALIS_HOME and detects that path relative to the Tomcat catalina.base property.
This is very useful for us because we place the oxalis home folder in the same location within the Tomcat folder. The absolute path to the Tomcat folder may vary across different environments or on developers' computers, making it inconsistent.
See change here:
https://rep.erst.dk/git/openebusiness/nemhandeledelivery/oxalis/-/blob/master/oxalis-commons/src/main/java/dk/erst/oxalis/commons/filesystem/detector/RelativePropertyHomeDetector.java
Type of Pull Request
Type of Change
Pull Request Checklist:
mvn clean installbefore commit and all tests run successfullymasterbranch