Skip to content

Conversation

@Kocal
Copy link
Contributor

@Kocal Kocal commented Nov 4, 2025

This PR increase version constraints on symfony/* packages to allow Symfony 8, which will be released this month.

- php: "8.3"
- php: "8.4"
- php: "8.4"
symfony-version: 8.0.x-dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding a job testing specifically Symfony 8.0.x-dev makes sense. A job using dev versions of dependency will already install the latest compatible dev version, which will be 8.0.x-dev now, but would automatically update to newer versions in the future without requiring additional maintenance work in the CI setup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be right, I removed it in a new commit.
Thanks!

- php: "8.3"
- php: "8.4"
- php: "8.4"
composer-stability: dev
Copy link
Member

@keradus keradus Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because of PHP-CS-Fixer itself:

➜  php-cs-fixer-cli-executor git:(symfony-8) ✗ sfcp why-not symfony/process ^8.0
friendsofphp/php-cs-fixer v3.89.1 requires symfony/process (^5.4.47 || ^6.4.24 || ^7.2) 

Couldn't we use the PHP-CS-Fixer shim?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can

simply without showing v8 on CI, we gamble if this change works

Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this small repo i do not mind that CI is not running Sf 8 yet.

I run it manually:

ker@dus cli-executor % composer info -D
maglnet/composer-require-checker 4.17.0      CLI tool to analyze composer dependencies and verify that no ...
phpunit/phpunit                  11.5.43     The PHP Unit Testing framework.
symfony/process                  8.0.0-BETA1 Executes commands in sub-processes
dariusz.ruminski@H9PJ7119CF cli-executor % ./vendor/bin/phpunit 
PHPUnit 11.5.43 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.14
Configuration: /Users/dariusz.ruminski/github/cli-executor/phpunit.xml.dist

...                                                                                                3 / 3 (100%)

Time: 00:00.241, Memory: 8.00 MB

@keradus keradus merged commit d236fd2 into PHP-CS-Fixer:master Nov 5, 2025
8 checks passed
@keradus
Copy link
Member

keradus commented Nov 5, 2025

thank you @Kocal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants