-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for Symfony 8 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/ci.yml
Outdated
| - php: "8.3" | ||
| - php: "8.4" | ||
| - php: "8.4" | ||
| symfony-version: 8.0.x-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think adding a job testing specifically Symfony 8.0.x-dev makes sense. A job using dev versions of dependency will already install the latest compatible dev version, which will be 8.0.x-dev now, but would automatically update to newer versions in the future without requiring additional maintenance work in the CI setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be right, I removed it in a new commit.
Thanks!
.github/workflows/ci.yml
Outdated
| - php: "8.3" | ||
| - php: "8.4" | ||
| - php: "8.4" | ||
| composer-stability: dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still installs symfony/process v7
https://github.com/PHP-CS-Fixer/cli-executor/actions/runs/19081571203/job/54521925562#step:5:86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because of PHP-CS-Fixer itself:
➜ php-cs-fixer-cli-executor git:(symfony-8) ✗ sfcp why-not symfony/process ^8.0
friendsofphp/php-cs-fixer v3.89.1 requires symfony/process (^5.4.47 || ^6.4.24 || ^7.2)
Couldn't we use the PHP-CS-Fixer shim?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can
simply without showing v8 on CI, we gamble if this change works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this small repo i do not mind that CI is not running Sf 8 yet.
I run it manually:
ker@dus cli-executor % composer info -D
maglnet/composer-require-checker 4.17.0 CLI tool to analyze composer dependencies and verify that no ...
phpunit/phpunit 11.5.43 The PHP Unit Testing framework.
symfony/process 8.0.0-BETA1 Executes commands in sub-processes
dariusz.ruminski@H9PJ7119CF cli-executor % ./vendor/bin/phpunit
PHPUnit 11.5.43 by Sebastian Bergmann and contributors.
Runtime: PHP 8.4.14
Configuration: /Users/dariusz.ruminski/github/cli-executor/phpunit.xml.dist
... 3 / 3 (100%)
Time: 00:00.241, Memory: 8.00 MB
|
thank you @Kocal |
This PR increase version constraints on
symfony/*packages to allow Symfony 8, which will be released this month.