Skip to content

Update PhpStan#4850

Merged
oleibman merged 4 commits intoPHPOffice:masterfrom
oleibman:updatestan
Apr 5, 2026
Merged

Update PhpStan#4850
oleibman merged 4 commits intoPHPOffice:masterfrom
oleibman:updatestan

Conversation

@oleibman
Copy link
Copy Markdown
Collaborator

@oleibman oleibman commented Apr 3, 2026

Too many errors when Dependabot tried. These seem mostly to involve implode, whose use is often embedded in other function calls. For that reason, these changes include a higher proportion than usual of // @phpstan-ignore-line.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • update development tools

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Too many errors when Dependabot tried. These seem mostly to involve `implode`, whose use is often embedded in other function calls. For that reason, these changes include a higher proportion than usual of `// @phpstan-ignore-line`.
@oleibman
Copy link
Copy Markdown
Collaborator Author

oleibman commented Apr 3, 2026

Coveralls is complaining because a line which was uncovered before was changed by the addition of phpstan-ignore-line, so it looks like a "new" uncovered statement, but it isn't really. This involves ribbon objects, which I am not willing to look at.

@oleibman oleibman added this pull request to the merge queue Apr 5, 2026
Merged via the queue into PHPOffice:master with commit 4a47607 Apr 5, 2026
15 checks passed
@oleibman oleibman deleted the updatestan branch April 5, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant