UHM-7260: Add Patient Flags module to the PIH EMR distro#440
UHM-7260: Add Patient Flags module to the PIH EMR distro#440mogoodrich wants to merge 1 commit intomasterfrom
Conversation
mseaton
left a comment
There was a problem hiding this comment.
Code looks fine, if you think the module is in good enough shape to add in, in it's current form.
|
Maybe this is famous last words, but I don't think it can hurt anything in it's current shape, especially if we don't have any flags set up. That being said, I think it may introduce some AOP, so maybe better to hold on this until after the LIberia release. |
Just add 5 new tables to the data model, add AOP around every EncounterService save, add additional spring context stuff that needs to startup, and add more modules to maintain, but yeah. On a more meta level, it's more subtly communicating that this is not something we are comfortable with in it's current form. |
No description provided.