Skip to content

RCT-326 add toast stating success/failure of form submission #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jday-plos merged 1 commit into from
Sep 23, 2025
Merged

RCT-326 add toast stating success/failure of form submission #3

jday-plos merged 1 commit into from
Sep 23, 2025
+13 −0

Conversation

@jday-plos
Copy link
Contributor

@jday-plos jday-plos commented Sep 16, 2025

https://plos.atlassian.net/browse/RCT-326

populates the messages field upon form submission in order to display a success/failure toast

Screenshot 2025-09-16 at 3 32 21 PM

JoshuaLavarine
JoshuaLavarine approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@JoshuaLavarine JoshuaLavarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @jday-plos 🎉

Image

@JoshuaLavarine
Copy link
Member

JoshuaLavarine commented Sep 22, 2025

Extra reminder to change the base branch from main to develop. Also, when you are ready to merge, we use the squash and merge option (although I've just realized that it is a single commit!! So maybe this is a reminder for next time 😆 ) :

Screenshot 2025-09-22 at 17 45 02

@JoshuaLavarine
Copy link
Member

JoshuaLavarine commented Sep 22, 2025

Also, if you are looking for the License Code, you can find it within the .xml attachment in this ticket. The code has a prefix of PLOS_, which is not required.

@jday-plos
Copy link
Contributor Author

jday-plos commented Sep 22, 2025

Extra reminder to change the base branch from main to develop. Also, when you are ready to merge, we use the squash and merge option (although I've just realized that it is a single commit!! So maybe this is a reminder for next time 😆 ) :

Screenshot 2025-09-22 at 17 45 02

I don't see a develop branch:
Screenshot 2025-09-22 at 1 49 13 PM

@JoshuaLavarine
Copy link
Member

JoshuaLavarine commented Sep 23, 2025

Sorry, Jeff!! I was thinking of production_transporter, which already has the develop branch. @RoseReatherford, should Jeff create develop as a clone of main?

@jday-plos jday-plos changed the base branch from main to develop September 23, 2025 21:30
@jday-plos jday-plos merged commit 667d8d2 into develop Sep 23, 2025
1 check passed
@jday-plos jday-plos deleted the rct-326 branch September 23, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RoseReatherford RoseReatherford RoseReatherford approved these changes

@JoshuaLavarine JoshuaLavarine JoshuaLavarine approved these changes

Assignees

@jday-plos jday-plos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jday-plos @JoshuaLavarine @RoseReatherford