Skip to content

Adding option to set q_max to a user specified value #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
astroJeff wants to merge 1 commit into
base: development-deprecated
Choose a base branch
from
Draft

Adding option to set q_max to a user specified value #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions posydon/popsyn/independent_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ def generate_primary_masses(number_of_binaries=1,


def generate_secondary_masses(primary_masses,
number_of_binaries=1,
q_min = 0.05,
q_max = 1.0,
secondary_mass_min=0.35,
secondary_mass_max=120,
secondary_mass_scheme='flat_mass_ratio',
Expand All @@ -318,8 +319,10 @@ def generate_secondary_masses(primary_masses,
----------
primary_masses : ndarray of floats
Previously drawn primary masses
number_of_binaries : int
Number of binaries that require randomly sampled orbital separations
q_min : float
Minimum secondary mass ratio
q_max : float
Maximum secondary mass ratio
secondary_mass_min : float
Minimum secondary mass
secondary_mass_max : float
Expand All @@ -344,12 +347,18 @@ def generate_secondary_masses(primary_masses,
if np.min(primary_masses) < secondary_mass_min:
raise ValueError("`secondary_mass_min` is "
"larger than some primary masses")

# Get the number of binaries
number_of_binaries = len(primary_masses)

# Generate secondary masses
if secondary_mass_scheme == 'flat_mass_ratio':
mass_ratio_min = np.max([secondary_mass_min / primary_masses,np.ones(len(primary_masses))*0.05], axis=0)
mass_ratio_max = np.min([secondary_mass_max / primary_masses,
np.ones(len(primary_masses))], axis=0)

mass_ratio_min = np.max([secondary_mass_min / primary_masses, np.ones(number_of_binaries)*q_min],
axis=0)
mass_ratio_max = np.min([secondary_mass_max / primary_masses, np.ones(number_of_binaries)*q_max],
axis=0)

secondary_masses = (
(mass_ratio_max - mass_ratio_min) * RNG.uniform(
size=number_of_binaries) + mass_ratio_min) * primary_masses
Expand Down