-
Notifications
You must be signed in to change notification settings - Fork 29
[enhancement] Clean POSYDON repository #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxbriel
wants to merge
12
commits into
main
Choose a base branch
from
mb_update_repo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ab7575c
remove data repository link
maxbriel eecfb65
remove old tests
maxbriel c4222e0
add all setup info into pyproject.toml
maxbriel 1835e4a
add setuptools to pyproject.toml
maxbriel 7fddde8
remove old setup.cfg config that was moved to pyproject.toml
maxbriel b824333
move to setuptools-scm for versioning
maxbriel 9b9462a
remove info
maxbriel 4e0168c
clean up CI with parameters in pyproject.toml
maxbriel d816a4e
fix script generation
maxbriel 0c8c257
fix merge issue
maxbriel 5abb2fc
Merge branch 'main' into mb_update_repo
maxbriel cc3a583
Merge branch 'main' into mb_update_repo
maxbriel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,3 @@ | ||
| [submodule "grid_params/POSYDON-MESA-INLISTS"] | ||
| path = grid_params/POSYDON-MESA-INLISTS | ||
| url = https://github.com/POSYDON-code/POSYDON-MESA-INLISTS.git | ||
| [submodule "data/POSYDON_data"] | ||
| path = data/POSYDON_data | ||
| url = https://github.com/POSYDON-code/POSYDON_data.git | ||
| [submodule "posydon/tests/data/POSYDON-UNIT-TESTS"] | ||
| path = posydon/tests/data/POSYDON-UNIT-TESTS | ||
| url = https://github.com/POSYDON-code/POSYDON-UNIT-TESTS.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| {% set name = "posydon" %} | ||
| {% set version = "2.2.6" %} | ||
|
|
||
| package: | ||
| name: "{{ name|lower }}" | ||
| version: "{{ version }}" | ||
| version: {{ GIT_DESCRIBE_TAG }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. minor stylistic suggestion: leave the quotes on
|
||
|
|
||
| source: | ||
| path: .. | ||
|
|
@@ -17,7 +16,8 @@ requirements: | |
| host: | ||
| - pip | ||
| - python==3.11 | ||
| - setuptools>=38.2.5 | ||
| - setuptools>=76.0.0 | ||
| - setuptools-scm>=8.0 | ||
|
|
||
| run: | ||
| - python==3.11 | ||
|
|
||
Submodule POSYDON_data
deleted from
e5d8d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we revert to the old
version: "{{ version }}"?Otherwise I think we can test if this works for us with a release after merging.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things seem to be working well. In my local test of
publish_conda, the tagv2.2.4gets picked up, I think because that is the latest tag this branch can grab.