[enhancement] Synthetic population lazy imports#798
Open
Conversation
maxbriel
changed the title
Contributor
|
LGTM except I think @astroJeff had the suggestion to move some of the lighter weight imports like |
|
|
||
| # speed of light | ||
| c = const.c.to("Mpc/yr").value # Mpc/yr | ||
| c = clight * 1.0227121650456949e-17 # cm/s to Mpc/yr |
Contributor
There was a problem hiding this comment.
Putting in that 1.0227121650456949e-17 factor make for a very hardcoded outlook :|
can we store this as a separate variable at the top instead? like this:
cm_per_sec_to_mpc_per_yr = 1.0227121650456949e-17
c = clight * cm_per_sec_to_mpc_per_yr
| raise ValueError("Model weight identifier not provided!") | ||
|
|
||
| import posydon.visualization.plot_pop as plot_pop | ||
| from posydon.utils.constants import Zsun |
Contributor
There was a problem hiding this comment.
Zsun seems to be used in a lot of places, we could keep this import at the top?
Contributor
|
@maxbriel since a lot of imports are now lazy, just checking if you’ve seen any new runtime errors? |
sgossage
approved these changes
Mar 16, 2026
Contributor
|
I've approved, but I think some of the comments above may still need to be addressed regarding a few imports moved back to the top. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importing from the synthetic population file often took longer than a few seconds, when loading for the first time
i.e.
from posydon.popsyn.synthetic_population import Population.This is mostly due to the amount of other parts of the code that are loaded.
This brings the loading down from 1870ms to 737ms
Tested with
python -X importtime -c "from posydon.popsyn.synthetic_population import Population"The imports are still not great. Part of this seems to be how much we import from other parts of posydon.
For example, posydon.popsyn.synthetic_population imports
popsyn.binarypopulation, andposydon.binary_evol.binarystar,etc, which is quite a large "time sink". See the attached image for the import time usage.Focus on the top-left of the below images. These show what is taking the longest to import.
original import time:
importtime from this rework.
