[v2.3] Binary population test suite and reorganizing dev-tools#817
Open
[v2.3] Binary population test suite and reorganizing dev-tools#817
dev-tools#817Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…OSYDON into sg_v2.3_binpop_test_suite
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…OSYDON into sg_v2.3_binpop_test_suite
…lt; this is code that would otherwise be repeated
for more information, see https://pre-commit.ci
…OSYDON into sg_v2.3_binpop_test_suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry picked version of PR#779 for v2.3.
This adds a population synthesis test suite and performs 4 tests currently:
BinaryPopulationsaving binaries to RAM.BinaryPopulationsaving to hdf5, plus check saved/loadedDataFrameis equivalent to binaries in RAM.BinaryPopulationsaving in multiple batch hdf5 files (i.e., w/optimize_ram = True).PopulationRunnerwith multiple metallicities1. TODO: add a flag to turn on/OFFWarning
We should check this vs. PR#780. Both PRs substantially restructure things in the
dev-toolsdirectory. Likely, we merge PR#780 first, then integrate it into this PR.This also reorganizes
dev-toolsas follows:where the
.inifiles are generated on-the-fly ininlists/and test output is saved to the variousoutput/subdirectories.Footnotes
PopulationRunnertest is implemented but disabled at the moment because it can break without appropriate system resources. This should be enabled prior to accepting this PR. (RAM fix helps here: PR#818). ↩