Open
Conversation
… be trained and created once at initialization, not every call
for more information, see https://pre-commit.ci
…ON into sg_v2.3_fix_ram_usage
for more information, see https://pre-commit.ci
…ON into sg_v2.3_fix_ram_usage
…rties when loading steps
for more information, see https://pre-commit.ci
…ON into sg_v2.3_fix_ram_usage
for more information, see https://pre-commit.ci
…eps and pass these to instances of TrackMatcher as needed.
…ON into sg_v2.3_fix_ram_usage
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ON into sg_v2.3_fix_ram_usage
…ON into sg_v2.3_fix_ram_usage
for more information, see https://pre-commit.ci
… evolution classes
…ON into sg_v2.3_fix_ram_usage
…t set of kwargs that may be accessed during simulation setup
for more information, see https://pre-commit.ci
…r instances. Now these are determined from each step's default kwargs
…ON into sg_v2.3_fix_ram_usage
…operties.py. Adding RNG kwarg to step_SN and using RNG object in places where randomness occurs
…p_detached. Also set default RNG in load_steps and load_a_step (simulationproperties.py)
for more information, see https://pre-commit.ci
…o pass an RNG during load_steps
…ON into sg_v2.3_rng_for_steps
for more information, see https://pre-commit.ci
Contributor
|
Can we check if this addresses issue #764? |
Contributor
Author
It does @astroJeff , running two separate populations with equal settings produces identical history data frames (ignoring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is branched from
sg_v2.3_fix_ram_usage(PR#818), so contains those changes as well.Changes in this PR occur in:
posydon/binary_evol/simulationproperties.pyposydon/binary_evol/SN/step_SN.pyposydon/binary_evol/DT/step_detached.pyposydon/binary_evol/MESA/step_mesa.pyposydon/popsyn/binarypopulation.pyposydon/utils/common_functions.pyposydon/unit_tests/utils/test_common_functions.pyIn order, the following has been changed:
RNGkeyword arguments forfrom_ini,load_stepsandload_a_stepso that aRNGobject may be passed to an evolution step.StepSNclass now looks for/builds anRNGobject and uses it to generate randomized SN kicks.detached_stepclass now looks for/builds anRNGobject and uses it to calculate Bondi-Hoyle accretion.MesaGridStepclass now looks for/builds anRNGobject and uses it to calculate Bondi-Hoyle accretion.BinaryPopulation, theentropyand resultantRNGobject set in your .ini may be passed on to evolution steps. Currently, onlystep_SN,detached_step, andMesaGridSteppick this up.bondi_hoyle()function can be passed an RNG object and it will be used to calculate the Bondi-Hoyle accretion rate.bondi_hoyle()has been updated accordingly.Now
step_SNcan have fixed kick outcomes ifentropyis set to a specific value in the .ini. Likewise forMesaGridStepanddetached_stepregarding Bondi-Hoyle accretion. This should allow us to run reproducible binary populations, fixed by theentropysetting.