Add leakage parameter for government infrastructure investment#1094
Open
MahadevBalla wants to merge 1 commit intoPSLmodels:masterfrom
Open
Add leakage parameter for government infrastructure investment#1094MahadevBalla wants to merge 1 commit intoPSLmodels:masterfrom
MahadevBalla wants to merge 1 commit intoPSLmodels:masterfrom
Conversation
jdebacker
reviewed
Apr 2, 2026
ogcore/fiscal.py
Outdated
| K_g (array_like): stock of public capital | ||
|
|
||
| """ | ||
| phi = p.infra_investment_leakage_rate |
Member
There was a problem hiding this comment.
Let's call this phi_g as in the doctoring.
Member
|
@MahadevBalla Thanks for the PR! I left one comment above. In addition, please run I would be good to update the theory docs in I will try to complete and merge PR #1097 soon -- once those changes are in this branch, the test failures we're seeing here should be resolved. |
d9344ad to
8504836
Compare
Author
|
Thanks for the review @jdebacker! I’ve made the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1086
Summary
infra_investment_leakage_ratetodefault_parameters.jsonfiscal.get_K_g()get_K_g()docstring to reflect the new law of motionTesting
pytest tests/test_fiscal.pypytest tests/test_fiscal.py -k "get_K_g"Output / Validation