Skip to content

adjust dimension bucket granularity from //3 to //4 #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lixinqi merged 1 commit into from
Mar 3, 2026
Merged

adjust dimension bucket granularity from //3 to //4 #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sqlite/graph_net_sample_bucket_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def __len__(self):


def get_default_dimension_bucket(dim: int) -> int:
"""Default bucket function: log2(dim) // 3"""
return -1 if dim <= 0 else int(math.log2(dim)) // 3
"""Default bucket function: log2(dim) // 4"""
return -1 if dim <= 0 else int(math.log2(dim)) // 4


def generate_sample_buckets(
Expand All @@ -70,7 +70,7 @@ def generate_sample_buckets(

Args:
session: SQLAlchemy session
get_dimension_bucket: bucket function, defaults to log2(dim) // 3
get_dimension_bucket: bucket function, defaults to log2(dim) // 4

Returns:
sample_type_results: List[SampleTypeBucketResult], results grouped by sample_type
Expand Down